[asterisk-dev] [Code Review] fix that ./runtests.py -t something doesn't match something_else

opticron reviewboard at asterisk.org
Mon Feb 27 13:35:29 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1771/#review5657
-----------------------------------------------------------

Ship it!


As currently documented, I think this patch is good to go.  A possible improvement that I would like to see would be to allow '-t' to be specified multiple times since this is doing away with the matching nature of '-t'.

- opticron


On Feb. 24, 2012, 3:02 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1771/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2012, 3:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> ./runtests.py -t tests/channels/SIP/sip_register
> 
> matched 
> 
> tests/channels/SIP/sip_register
> tests/channels/SIP/sip_register_domain_acl
> 
> with patch it only matches
> 
> tests/channels/SIP/sip_register
> 
> 
> (The whole -t bit could use a bit of refactoring, this is just a quick-fix.)
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/runtests.py 3064 
> 
> Diff: https://reviewboard.asterisk.org/r/1771/diff
> 
> 
> Testing
> -------
> 
> tests/channels/SIP
> 
> still matches all SIP tests.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120227/38d3f23a/attachment.htm>


More information about the asterisk-dev mailing list