[asterisk-dev] [Code Review]: Enable gosub use in connected line, redirecting, and ccss

[opticron]

> On Feb. 22, 2012, 11:50 a.m., Mark Michelson wrote:
> > Besides what I've mentioned here, I think you should also go through the affected areas where macros are either configured or executed and add some deprecation warning messages.

Missed this comment on my read through today.  Will address deprecation warnings tomorrow.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1760/#review5583
-----------------------------------------------------------


On Feb. 26, 2012, 6:58 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1760/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2012, 6:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> To help along the deprecation of app_macro, this enables the use of app_stack (aka GoSub) in relation to connected line, redirecting, and call completion supplementary services.  The only major changes between the two implementations involve dropping the distinction between caller and callee for connected line and redirecting since this distinction never really made sense in the first place.
> 
> 
> This addresses bug SWP-4254.
>     https://issues.asterisk.org/jira/browse/SWP-4254
> 
> 
> Diffs
> -----
> 
>   trunk/main/rtp_engine.c 356213 
>   trunk/main/dial.c 356213 
>   trunk/main/features.c 356213 
>   trunk/main/channel.c 356213 
>   trunk/main/ccss.c 356213 
>   trunk/UPGRADE.txt 356213 
>   trunk/apps/app_dial.c 356213 
>   trunk/apps/app_followme.c 356213 
>   trunk/apps/app_queue.c 356213 
>   trunk/configs/ccss.conf.sample 356213 
>   trunk/include/asterisk/app.h 356213 
>   trunk/include/asterisk/ccss.h 356213 
>   trunk/include/asterisk/channel.h 356213 
>   trunk/main/app.c 356213 
> 
> Diff: https://reviewboard.asterisk.org/r/1760/diff
> 
> 
> Testing
> -------
> 
> Tested with the new tests to go with these changes here: https://reviewboard.asterisk.org/r/1761/
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120227/a22e4a4f/attachment.htm>