[asterisk-dev] [Code Review] Enable gosub use in connected line, redirecting, and ccss

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1760/
-----------------------------------------------------------

(Updated Feb. 26, 2012, 6:58 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed buffer overflow issue, formatting issues, and made subroutine take priority over macro calls if both variables are set.


Summary
-------

To help along the deprecation of app_macro, this enables the use of app_stack (aka GoSub) in relation to connected line, redirecting, and call completion supplementary services.  The only major changes between the two implementations involve dropping the distinction between caller and callee for connected line and redirecting since this distinction never really made sense in the first place.


This addresses bug SWP-4254.
    https://issues.asterisk.org/jira/browse/SWP-4254


Diffs (updated)
-----

  trunk/main/rtp_engine.c 356213 
  trunk/main/dial.c 356213 
  trunk/main/features.c 356213 
  trunk/main/channel.c 356213 
  trunk/main/ccss.c 356213 
  trunk/UPGRADE.txt 356213 
  trunk/apps/app_dial.c 356213 
  trunk/apps/app_followme.c 356213 
  trunk/apps/app_queue.c 356213 
  trunk/configs/ccss.conf.sample 356213 
  trunk/include/asterisk/app.h 356213 
  trunk/include/asterisk/ccss.h 356213 
  trunk/include/asterisk/channel.h 356213 
  trunk/main/app.c 356213 

Diff: https://reviewboard.asterisk.org/r/1760/diff


Testing
-------

Tested with the new tests to go with these changes here: https://reviewboard.asterisk.org/r/1761/


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120227/da0a1591/attachment-0001.htm>