[asterisk-dev] [Code Review] Add tests for connected line, redirecting, and csss to test new gosub calls

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1761/#review5585
-----------------------------------------------------------

Ship it!


Tests look fine to me aside from the suggestion below.


asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1761/#comment10222>

    You could pass the args as part of your UserEvent so that the test can make sure the args are being passed to the macro properly. This can be done for all the macro/gosub tests.


- Mark


On Feb. 21, 2012, 7:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1761/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2012, 7:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add tests for the existing macro and new gosub calls in relation to connected line, redirecting, and ccss.
> 
> 
> This addresses bug SWP-4254.
>     https://issues.asterisk.org/jira/browse/SWP-4254
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/generic_ccss/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3036 
>   asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/connected_line/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/connected_line/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/run-test PRE-CREATION 
>   asterisk/trunk/tests/redirecting/macro/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/run-test PRE-CREATION 
>   asterisk/trunk/tests/redirecting/subroutine/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/redirecting/tests.yaml PRE-CREATION 
>   asterisk/trunk/tests/tests.yaml 3036 
> 
> Diff: https://reviewboard.asterisk.org/r/1761/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120222/63bfb58c/attachment.htm>