<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1761/">https://reviewboard.asterisk.org/r/1761/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests look fine to me aside from the suggestion below.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1761/diff/1/?file=24475#file24475line26" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">exten => s,n,UserEvent(CLStatus,status: caller connected line macro)</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could pass the args as part of your UserEvent so that the test can make sure the args are being passed to the macro properly. This can be done for all the macro/gosub tests.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On February 21st, 2012, 7:48 p.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2012, 7:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add tests for the existing macro and new gosub calls in relation to connected line, redirecting, and ccss.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-4254">SWP-4254</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/configs/ast2/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/generic_ccss/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(3036)</span></li>
<li>asterisk/trunk/tests/connected_line/macro/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/macro/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/macro/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/subroutine/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/subroutine/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/subroutine/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/connected_line/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/macro/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/macro/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/macro/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/subroutine/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/subroutine/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/subroutine/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/redirecting/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/tests.yaml <span style="color: grey">(3036)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1761/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>