[asterisk-dev] [Code Review] Constify some more channel driver technology callback parameters.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1707/#review5369
-----------------------------------------------------------

Ship it!


It all looks good to me. Just keep your eyes on what bamboo reports when it tries to compile just in case you missed some modules or if there are oddities with certain compiler versions.

- Mark


On Feb. 1, 2012, 1:02 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1707/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2012, 1:02 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> Constifying: ast_request, requester callback, devicestate callback, ast_call, and call callback as principle constification
> 
> With ast_request_and_dial, __ast_request_and_dial, ast_pbx_outgoing_exten, and ast_pbx_outgoing_app as ripple constification.
> 
> 
> Diffs
> -----
> 
>   /trunk/addons/chan_mobile.c 353684 
>   /trunk/addons/chan_ooh323.c 353684 
>   /trunk/apps/app_confbridge.c 353684 
>   /trunk/channels/chan_agent.c 353684 
>   /trunk/channels/chan_alsa.c 353684 
>   /trunk/channels/chan_bridge.c 353684 
>   /trunk/channels/chan_console.c 353684 
>   /trunk/channels/chan_dahdi.c 353684 
>   /trunk/channels/chan_gtalk.c 353684 
>   /trunk/channels/chan_h323.c 353684 
>   /trunk/channels/chan_iax2.c 353684 
>   /trunk/channels/chan_jingle.c 353684 
>   /trunk/channels/chan_local.c 353684 
>   /trunk/channels/chan_mgcp.c 353684 
>   /trunk/channels/chan_misdn.c 353684 
>   /trunk/channels/chan_multicast_rtp.c 353684 
>   /trunk/channels/chan_nbs.c 353684 
>   /trunk/channels/chan_oss.c 353684 
>   /trunk/channels/chan_phone.c 353684 
>   /trunk/channels/chan_sip.c 353684 
>   /trunk/channels/chan_skinny.c 353684 
>   /trunk/channels/chan_unistim.c 353684 
>   /trunk/channels/chan_usbradio.c 353684 
>   /trunk/channels/chan_vpb.cc 353684 
>   /trunk/channels/sig_analog.h 353684 
>   /trunk/channels/sig_analog.c 353684 
>   /trunk/channels/sig_pri.h 353684 
>   /trunk/channels/sig_pri.c 353684 
>   /trunk/channels/sig_ss7.h 353684 
>   /trunk/channels/sig_ss7.c 353684 
>   /trunk/include/asterisk/channel.h 353684 
>   /trunk/include/asterisk/pbx.h 353684 
>   /trunk/main/channel.c 353684 
>   /trunk/main/features.c 353684 
>   /trunk/main/manager.c 353684 
>   /trunk/main/pbx.c 353684 
>   /trunk/pbx/pbx_spool.c 353684 
> 
> Diff: https://reviewboard.asterisk.org/r/1707/diff
> 
> 
> Testing
> -------
> 
> Compiler is still happy that the types match.  Also was able to remove several casts that are no longer needed.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120201/50002b08/attachment.htm>