<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1707/">https://reviewboard.asterisk.org/r/1707/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It all looks good to me. Just keep your eyes on what bamboo reports when it tries to compile just in case you missed some modules or if there are oddities with certain compiler versions.</pre>
<br />
<p>- Mark</p>
<br />
<p>On February 1st, 2012, 1:02 p.m., rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated Feb. 1, 2012, 1:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Constifying: ast_request, requester callback, devicestate callback, ast_call, and call callback as principle constification
With ast_request_and_dial, __ast_request_and_dial, ast_pbx_outgoing_exten, and ast_pbx_outgoing_app as ripple constification.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiler is still happy that the types match. Also was able to remove several casts that are no longer needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/addons/chan_mobile.c <span style="color: grey">(353684)</span></li>
<li>/trunk/addons/chan_ooh323.c <span style="color: grey">(353684)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_alsa.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_bridge.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_console.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_h323.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_multicast_rtp.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_nbs.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_oss.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_usbradio.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/chan_vpb.cc <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/sig_analog.h <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/sig_pri.h <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/sig_ss7.h <span style="color: grey">(353684)</span></li>
<li>/trunk/channels/sig_ss7.c <span style="color: grey">(353684)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(353684)</span></li>
<li>/trunk/include/asterisk/pbx.h <span style="color: grey">(353684)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(353684)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(353684)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(353684)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(353684)</span></li>
<li>/trunk/pbx/pbx_spool.c <span style="color: grey">(353684)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1707/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>