[asterisk-dev] [Code Review] Add test for proper handling of 422 responses

opticron reviewboard at asterisk.org
Mon Dec 31 16:15:32 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2223/
-----------------------------------------------------------

(Updated Dec. 31, 2012, 4:15 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address Matt's comments.


Summary
-------

This test ensures that Asterisk handles 422 responses properly by checking that it includes Min-SE with the proper value on subsequent call attempts.


This addresses bug SWP-5051.
    https://issues.asterisk.org/jira/browse/SWP-5051


Diffs (updated)
-----

  asterisk/trunk/lib/python/asterisk/PluggableModules.py PRE-CREATION 
  asterisk/trunk/sample-yaml/originator-config.yaml.sample PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml 3586 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/configs/ast1/sip.conf PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/sipp/uas-no-hangup.xml PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/test-config.yaml PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/configs/ast1/extensions.conf PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/configs/ast1/sip.conf PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/sipp/uas-no-hangup.xml PRE-CREATION 
  asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/test-config.yaml PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2223/diff


Testing
-------

Creating this test found the bug reported in https://reviewboard.asterisk.org/r/2222/  This test passes with that patch in place.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121231/465216ea/attachment-0001.htm>


More information about the asterisk-dev mailing list