[asterisk-dev] [Code Review]: Add test for proper handling of 422 responses

[opticron]

> On Dec. 31, 2012, 9:53 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/originator.py, lines 17-24
> > <https://reviewboard.asterisk.org/r/2223/diff/2/?file=32407#file32407line17>
> >
> >     This could be put in lib at this point.
> >     
> >     It feels like we're getting to the point where we have several small, useful pluggable modules. I think we could have a single python module that contained a number of these, where Originator would simply be a class in that module. If you go that route, I'd change this class to do the following:
> >     
> >     * Make the originate completely configurable. It should accept a channel target, an application or context/extension/priority pair, as well as a parameter that determines whether or not a failed origination is actually a test failure.
> >     * Make where the origination starts configurable. This could be:
> >     ** AMI connect
> >     ** Scenario start
> >     ** Possibly random AMI event callback, but that could be deferred if needed.

Done.  It does not currently have the AMI event callback option, but it should be relatively easy to do with a modified version of AMICallbackInstance.  I'll take a look at that on Wednesday.


> On Dec. 31, 2012, 9:53 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/test-config.yaml, line 7
> > <https://reviewboard.asterisk.org/r/2223/diff/2/?file=32409#file32409line7>
> >
> >     This really shouldn't be 1.8.0, since it passes with a patch put in place. It should be the minimum version of 1.8 with that patch.
> >     
> >     This comment applies to both tests.

Done.


> On Dec. 31, 2012, 9:53 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/test-config.yaml, line 14
> > <https://reviewboard.asterisk.org/r/2223/diff/2/?file=32409#file32409line14>
> >
> >     What is the 'timers' tag? Why would anyone run a test with only 'timers'?
> >     
> >     If the tag is meant to represent SIP session timers, then I'd prefer the tag to be a bit more descriptive.
> >     
> >     This comment applies to both tests.

Changed to SIP_session_timers for these tests. Assuming that's acceptable, I'll fix the rest of them as well.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2223/#review7587
-----------------------------------------------------------


On Dec. 13, 2012, 9:11 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2223/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 9:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test ensures that Asterisk handles 422 responses properly by checking that it includes Min-SE with the proper value on subsequent call attempts.
> 
> 
> This addresses bug SWP-5051.
>     https://issues.asterisk.org/jira/browse/SWP-5051
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml 3576 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/originator.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/originator.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2223/diff
> 
> 
> Testing
> -------
> 
> Creating this test found the bug reported in https://reviewboard.asterisk.org/r/2222/  This test passes with that patch in place.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121231/11e80404/attachment.htm>