[asterisk-dev] [Code Review] Fix The Queue Log Reporting That All Calls Ending As COMPLETECALLER When The h Extension Is Present

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2256/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

When the "h" extension is present within the context of the queue, all calls are being reported COMPLETECALLER even when the agent is hanging up the call.

This patch checks to see if the agent hung-up or not instead of only relying on checking if the queue (caller) channel hung-up or not.  It would appear that having the h extension in the mix, the pbx goes to the h extension, "hanging-up" the queue channel and triggering the reporting of COMPLETECALLER.


This addresses bug ASTERISK-20743.
    https://issues.asterisk.org/jira/browse/ASTERISK-20743


Diffs
-----

  /branches/1.8/apps/app_queue.c 378145 

Diff: https://reviewboard.asterisk.org/r/2256/diff


Testing
-------

Tested this on dev box.  I tested with the "h" extension and without it, to make sure that the call is being reported properly as either COMPLETECALLER or COMPLETEAGENT depending on who hung-up.

The reporter also tested the patch and confirmed that it was working for them.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121230/a0159921/attachment.htm>