[asterisk-dev] [Code Review] Fix SIP Notify Messages To Have The Proper IP Address In The FROM Field

elguero reviewboard at asterisk.org
Sat Dec 29 21:34:30 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2255/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

On a multihomed server, when sending a NOTIFY message we are not figuring out which network should be used to contact the peer that the message is going to.

This patch fixes the problem by calling ast_sip_ouraddrfor() and then build_via() so that our NOTIFY message contains the correct IP address.


This addresses bug ASTERISK-20805.
    https://issues.asterisk.org/jira/browse/ASTERISK-20805


Diffs
-----

  /branches/1.8/channels/chan_sip.c 378070 

Diff: https://reviewboard.asterisk.org/r/2255/diff


Testing
-------

Tested on dev box and the reporter also tested it in his environment.


Thanks,

elguero

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121230/0e24c584/attachment.htm>


More information about the asterisk-dev mailing list