[asterisk-dev] [Code Review] testsuite bridge tests: Add some additional features to automon and automixmon tests

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2250/
-----------------------------------------------------------

Review request for Asterisk Developers, Mark Michelson and kmoore.


Summary
-------

Originally monitor tests covered only starting monitor and BRIDGE_FEATURES method was only tested for the calling channel (This test actually uncovered a bug that being that the called channel could not have features set with BRIDGE_FEATURES. This has been corrected). Now the test covers the following:

 * Monitor feature set via Dial on caller - start and stop. Make sure feature is not detected for callee.
 * Monitor feature set via Dial on callee - start and stop. Make sure feature is not detected for caller.
 * Monitor feature set via BRIDGE_FEATURES on caller - start and stop. Make sure feature is not detected for callee.
 * Monitor feature set via BRIDGE_FEATURES on callee - start and stop. Make sure feature is not detected for caller.

The automixmon tests underwent similar changes, but no use of the BRIDGE_FEATURES method was in place for automixmon. This revealed that the BRIDGE_FEATURES variable method had no support for automixmon. This mistake has also been corrected. Test now covers the following:

 * MixMonitor feature set via Dial on caller - start and stop. Make sure feature is not detected for callee.
 * MixMonitor feature set via Dial on callee - start and stop. Make sure feature is not detected for caller.
 * MixMonitor feature set via BRIDGE_FEATURES on caller - start and stop. Make sure feature is not detected for callee.
 * MixMonitor feature set via BRIDGE_FEATURES on callee - start and stop. Make sure feature is not detected for caller.


Diffs
-----

  /asterisk/trunk/tests/bridge/automixmon/configs/ast1/extensions.conf 3580 
  /asterisk/trunk/tests/bridge/automixmon/test-config.yaml 3580 
  /asterisk/trunk/tests/bridge/automon/configs/ast1/extensions.conf 3580 
  /asterisk/trunk/tests/bridge/automon/test-config.yaml 3580 

Diff: https://reviewboard.asterisk.org/r/2250/diff


Testing
-------

Ran the tests, made sure the CEL logs matched expectations, made sure all feature detection expected shows up in full log.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121219/5c0cc824/attachment.htm>