<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2250/">https://reviewboard.asterisk.org/r/2250/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson and kmoore.</div>
<div>By jrose.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Originally monitor tests covered only starting monitor and BRIDGE_FEATURES method was only tested for the calling channel (This test actually uncovered a bug that being that the called channel could not have features set with BRIDGE_FEATURES. This has been corrected). Now the test covers the following:
* Monitor feature set via Dial on caller - start and stop. Make sure feature is not detected for callee.
* Monitor feature set via Dial on callee - start and stop. Make sure feature is not detected for caller.
* Monitor feature set via BRIDGE_FEATURES on caller - start and stop. Make sure feature is not detected for callee.
* Monitor feature set via BRIDGE_FEATURES on callee - start and stop. Make sure feature is not detected for caller.
The automixmon tests underwent similar changes, but no use of the BRIDGE_FEATURES method was in place for automixmon. This revealed that the BRIDGE_FEATURES variable method had no support for automixmon. This mistake has also been corrected. Test now covers the following:
* MixMonitor feature set via Dial on caller - start and stop. Make sure feature is not detected for callee.
* MixMonitor feature set via Dial on callee - start and stop. Make sure feature is not detected for caller.
* MixMonitor feature set via BRIDGE_FEATURES on caller - start and stop. Make sure feature is not detected for callee.
* MixMonitor feature set via BRIDGE_FEATURES on callee - start and stop. Make sure feature is not detected for caller.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran the tests, made sure the CEL logs matched expectations, made sure all feature detection expected shows up in full log.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/bridge/automixmon/configs/ast1/extensions.conf <span style="color: grey">(3580)</span></li>
<li>/asterisk/trunk/tests/bridge/automixmon/test-config.yaml <span style="color: grey">(3580)</span></li>
<li>/asterisk/trunk/tests/bridge/automon/configs/ast1/extensions.conf <span style="color: grey">(3580)</span></li>
<li>/asterisk/trunk/tests/bridge/automon/test-config.yaml <span style="color: grey">(3580)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2250/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>