[asterisk-dev] Proposed Review board Usage policy change

[Mark Michelson]

Hi everyone,

At Astricon in October, one policy that came up was the idea to give 
everyone around the world a fair shot at reading the content on the 
review board. As such, I am proposing the following to be added to the 
"Reviewboard Usage" wiki page:

"When someone approves of a review request, they will click the "Ship 
it!" button as a way of signing off on the review. When you have 
received a "Ship it!" you can feel confident that in the opinion of one 
person, your code has met approval.

Since Asterisk is a global project, it is important that people around 
the world get a fair chance to review your code before the review is 
closed. If your code receives a "Ship it!" but has not been on the 
review board for at least 24 hours, please refrain from committing. It 
may be that a reviewer on the opposite side of the planet has a valid 
objection to your code but has not had the chance to express 
himself/herself. If the code has been up for at least 24 hours, it is 
reasonable to assume that the code has been given a fair chance to be 
reviewed by anyone interested. Ideally, you should give another 24 hours 
after the initial "Ship it!" so that people can have one last 
opportunity to bring up any objections.

Exceptions to this policy may be enacted if the fix is time-sensitive, 
such as if the fix is determined to be security-related or if the fix is 
for a widely-felt catastrophic regression."


Please let me know what you think.

Mark Michelson