[asterisk-dev] [Code Review] Remove HAVE_DEV_URANDOM

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2245/#review7532
-----------------------------------------------------------

Ship it!


I like how 'convert to a runtime check' really means 'remove compile time check since we do the runtime check anyways'.

- David


On Dec. 13, 2012, 9:54 a.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2245/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 9:54 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> HAVE_DEV_URANDOM is a problematic check.  It's not valid when cross compiling or for packages.  The only place it was used was pretty easy to convert to a runtime check.  Just try to open() it and only use it if the open() worked.
> 
> If this goes in, opinions on which branches?
> 
> 
> Diffs
> -----
> 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 377975 
>   /trunk/include/asterisk/autoconfig.h.in 377975 
>   /trunk/main/utils.c 377975 
> 
> Diff: https://reviewboard.asterisk.org/r/2245/diff
> 
> 
> Testing
> -------
> 
> Compiled it.
> 
> 
> Thanks,
> 
> Russell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121213/323a6664/attachment-0001.htm>