[asterisk-dev] [Code Review]: Add test for proper handling of 422 responses

[opticron]

> On Dec. 12, 2012, 10:54 a.m., Mark Michelson wrote:
> > I think it would be worthwhile to add a test case where Asterisk's session timers are set to originate mode. I think this would be a more common case where a 422 is received in response to our INVITE.

Updated with new version of the test.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2223/#review7523
-----------------------------------------------------------


On Dec. 13, 2012, 9:11 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2223/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 9:11 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test ensures that Asterisk handles 422 responses properly by checking that it includes Min-SE with the proper value on subsequent call attempts.
> 
> 
> This addresses bug SWP-5051.
>     https://issues.asterisk.org/jira/browse/SWP-5051
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml 3576 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/originator.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_accept/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/originator.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422_originate/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2223/diff
> 
> 
> Testing
> -------
> 
> Creating this test found the bug reported in https://reviewboard.asterisk.org/r/2222/  This test passes with that patch in place.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121213/1f32a8e5/attachment.htm>