[asterisk-dev] [Code Review] Add test for proper handling of 422 responses

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2223/#review7523
-----------------------------------------------------------


I think it would be worthwhile to add a test case where Asterisk's session timers are set to originate mode. I think this would be a more common case where a 422 is received in response to our INVITE.

- Mark


On Nov. 30, 2012, 4:26 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2223/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 4:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test ensures that Asterisk handles 422 responses properly by checking that it includes Min-SE with the proper value on subsequent call attempts.
> 
> 
> This addresses bug SWP-5051.
>     https://issues.asterisk.org/jira/browse/SWP-5051
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml 3551 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422/originator.py PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422/sipp/uas-no-hangup.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/session_timers/uac_multiple_422/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2223/diff
> 
> 
> Testing
> -------
> 
> Creating this test found the bug reported in https://reviewboard.asterisk.org/r/2222/  This test passes with that patch in place.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121212/e9d83d0a/attachment.htm>