[asterisk-dev] [Code Review] Handle Session-Expires less than local Min-SE in 200 OK

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2237/#review7507
-----------------------------------------------------------

Ship it!


Might as well create a test for the Test Suite using the modified SIPp scenario as well.


branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2237/#comment14293>

    Since an invalid refresher value in parse_session_expires produces an AST_WARNING, it seems fair that a value we determine is invalid for the actual min interval should also produce a warning.  The effect is the same in both cases - we hang up the call - so they probably both deserve a WARNING.



branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2237/#comment14292>

    Blob


- Matt


On Dec. 7, 2012, 5:01 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2237/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 5:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Currently, all versions of Asterisk will accept any value for Session-Expires in an incoming 200 OK as long as it's parseable as a number.  This includes values less than the local Min-SE and even values less than the RFC-defined minimum of 90.  This patch ensures that calls setup in this scenario are immediately torn down.
> 
> 
> This addresses bug ASTERISK-20653.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20653
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 377388 
> 
> Diff: https://reviewboard.asterisk.org/r/2237/diff
> 
> 
> Testing
> -------
> 
> Tested with a tweaked version of an existing integration test (basic_uac_refresh).
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121207/2c39b944/attachment.htm>