[asterisk-dev] [Code Review] Handle Session-Expires less than local Min-SE in 200 OK
opticron
reviewboard at asterisk.org
Fri Dec 7 17:01:29 CST 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2237/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
Currently, all versions of Asterisk will accept any value for Session-Expires in an incoming 200 OK as long as it's parseable as a number. This includes values less than the local Min-SE and even values less than the RFC-defined minimum of 90. This patch ensures that calls setup in this scenario are immediately torn down.
This addresses bug ASTERISK-20653.
https://issues.asterisk.org/jira/browse/ASTERISK-20653
Diffs
-----
branches/1.8/channels/chan_sip.c 377388
Diff: https://reviewboard.asterisk.org/r/2237/diff
Testing
-------
Tested with a tweaked version of an existing integration test (basic_uac_refresh).
Thanks,
opticron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121207/8d87d098/attachment.htm>
More information about the asterisk-dev
mailing list