[asterisk-dev] [Code Review] dsp.c: dtmf_detect, Fix multiple issues when no-interdigit delay is present.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2085/#review6995
-----------------------------------------------------------


Looks good.  Only found minor issues.


trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2085/#comment13607>

    I think this is a stray asterisk:
    DRC * and then
    
    or is this an asterisk for the note
    * or optionally...



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2085/#comment13605>

    Nit-pick:
    
    /*
     * Multi-line
     * comments
     * look better this way.
     */



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2085/#comment13600>

    Clearing misses not necessary.  We no longer are in the DRC case.



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2085/#comment13604>

    Typo: wiithout



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2085/#comment13602>

    Clearing misses not necessary.  We no longer are in the DRC case.



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2085/#comment13603>

    Clearing misses not necessary.  We no longer are in the DRC case.



trunk/main/dsp.c
<https://reviewboard.asterisk.org/r/2085/#comment13606>

    I think this is a stray asterisk:
    DRC * and then


- rmudgett


On Aug. 31, 2012, 6:27 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2085/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 6:27 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Document DTMF events for different sequences.
> 
> * Fix extra hit required when new DIGIT is sent without any interdigit delay.
> * Fix when DTMF_HITS_TO_BEGIN = 2, and no interdigit gap, that BEGIN is posted. 
> * Fix situation where a flakey detect, would clear the current_hit (indicating an END), which may not have been the case.
> 
> 
> Diffs
> -----
> 
>   trunk/main/dsp.c 371689 
> 
> Diff: https://reviewboard.asterisk.org/r/2085/diff
> 
> 
> Testing
> -------
> 
> On production box for 24 hours. 888 digit's now received.
> 
> The change here doesn't affect normal tone on/tone off, it changes the case when no interdigit pause is received between 2 digits, now the 2 digit has the same detect time as if there had been an interdigit pause before hand.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120831/9d57500d/attachment-0001.htm>