[asterisk-dev] [Code Review] dsp.c: dtmf_detect, Fix multiple issues when no-interdigit delay is present.

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2085/
-----------------------------------------------------------

(Updated Aug. 31, 2012, 6:27 a.m.)


Review request for Asterisk Developers.


Changes
-------

Starting again.

Not as simple as before. but I believe takes into account all possible conditions.
no interdigit gap, with and END before a new BEGIN.

Now where hits_to_begin = 4 and misses_to_end = 3  
 -----AAAA  misses=0, hits=4,     BEGIN A
 ----AAAAB  misses=1, hits=1,     no action
 ---AAAABC  misses=2, hits=1,     no action
 --AAAABCC  misses=3, hits=2      END A
 -AAAABCCC  misses=0, hits=3      no action
 AAAABCCCC  misses=0, hits=4      BEGIN C


Summary
-------

Document DTMF events for different sequences.

* Fix extra hit required when new DIGIT is sent without any interdigit delay.
* Fix when DTMF_HITS_TO_BEGIN = 2, and no interdigit gap, that BEGIN is posted. 
* Fix situation where a flakey detect, would clear the current_hit (indicating an END), which may not have been the case.


Diffs (updated)
-----

  trunk/main/dsp.c 371689 

Diff: https://reviewboard.asterisk.org/r/2085/diff


Testing
-------

On production box for 24 hours. 888 digit's now received.

The change here doesn't affect normal tone on/tone off, it changes the case when no interdigit pause is received between 2 digits, now the 2 digit has the same detect time as if there had been an interdigit pause before hand.


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120831/b4718164/attachment-0001.htm>