[asterisk-dev] [Code Review] Deprecate chan_gtalk, chan_jingle, and res_jabber in preference of chan_motif and res_xmpp

Matt Jordan reviewboard at asterisk.org
Thu Aug 23 16:45:15 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2082/#review6957
-----------------------------------------------------------


I'm acknowledging the underlying issue, but I'd prefer to see some discussion of this patch before we commit it.  I'd hate to have this go into Asterisk 11.0.0-beta2, and have people feel like this was done without enough discussion.

- Matt


On Aug. 23, 2012, 7:30 a.m., Leif Madsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2082/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2012, 7:30 a.m.)
> 
> 
> Review request for Asterisk Developers, Russell Bryant and Joshua Colp.
> 
> 
> Summary
> -------
> 
> Modify markup for chan_gtalk, chan_jingle, and res_jabber in order to deprecate them. Add replacement markup pointer to chan_motif and res_xmpp.
> 
> 
> This addresses bug ASTERISK-20298.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20298
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_jingle.c 371641 
>   /branches/11/res/res_jabber.c 371641 
>   /branches/11/channels/chan_gtalk.c 371641 
> 
> Diff: https://reviewboard.asterisk.org/r/2082/diff
> 
> 
> Testing
> -------
> 
> Executed make validate-docs to verify markup was valid. Ran make menuselect to verify modules live under the deprecated header, and show the correct replaced by.
> 
> 
> Thanks,
> 
> Leif
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120823/063319f2/attachment.htm>


More information about the asterisk-dev mailing list