<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2082/">https://reviewboard.asterisk.org/r/2082/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm acknowledging the underlying issue, but I'd prefer to see some discussion of this patch before we commit it. I'd hate to have this go into Asterisk 11.0.0-beta2, and have people feel like this was done without enough discussion.</pre>
<br />
<p>- Matt</p>
<br />
<p>On August 23rd, 2012, 7:30 a.m., Leif Madsen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Russell Bryant and Joshua Colp.</div>
<div>By Leif Madsen.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2012, 7:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Modify markup for chan_gtalk, chan_jingle, and res_jabber in order to deprecate them. Add replacement markup pointer to chan_motif and res_xmpp.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Executed make validate-docs to verify markup was valid. Ran make menuselect to verify modules live under the deprecated header, and show the correct replaced by.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20298">ASTERISK-20298</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/channels/chan_jingle.c <span style="color: grey">(371641)</span></li>
<li>/branches/11/res/res_jabber.c <span style="color: grey">(371641)</span></li>
<li>/branches/11/channels/chan_gtalk.c <span style="color: grey">(371641)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2082/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>