[asterisk-dev] [Code Review]: Add recording tests for ConfBridge

[Matt Jordan]

> On April 27, 2012, 8:59 a.m., opticron wrote:
> > /asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf, line 25
> > <https://reviewboard.asterisk.org/r/1880/diff/1/?file=27512#file27512line25>
> >
> >     Is there any reason not to use Echo() here?

Yes - we don't want media to be echoed.  If any media is received by this channel, it should simply be absorbed and ignored.


> On April 27, 2012, 8:59 a.m., opticron wrote:
> > /asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf, line 20
> > <https://reviewboard.asterisk.org/r/1880/diff/1/?file=27512#file27512line20>
> >
> >     Is this extension actually used?  Maybe you meant to use the 'h' extension?

Nope.  This extension is called to hang up the channel.

I think there's some confusion here as to what is going on.  The set of extensions in [caller] are used to control a channel that feeds data into the ConfBridge application.  This can be playing back a file, sending DTMF, waiting indefinitely (in the case where we aren't taking any actions), or hanging up.  In this particular case, this extension hangs up this channel, mimicking a caller into ConfBridge hanging up.


> On April 27, 2012, 8:59 a.m., opticron wrote:
> > /asterisk/trunk/tests/apps/confbridge/confbridge_recording/run-test, line 164
> > <https://reviewboard.asterisk.org/r/1880/diff/1/?file=27513#file27513line164>
> >
> >     namedtuple is only available in python 2.6+ while centos5 runs python 2.4.

Will change to a dictionary. :-(


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1880/#review6086
-----------------------------------------------------------


On April 23, 2012, 8:27 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1880/
> -----------------------------------------------------------
> 
> (Updated April 23, 2012, 8:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a test to the Asterisk Test Suite to verify the recording of conferences by ConfBridge.  It checks three scenarios:
> 
> 1) Setting the record_conference bridge setting using the CONFBRIDGE function and using the default file name provided by the ConfBridge application.
> 2) Setting the record_conference and record_file bridge settings using the CONFBRIDGE function.
> 3) Using a non-default bridge profile from the ConfBridge config file.
> 
> In each scenario, a local channel is placed into a ConfBridge and a sound file containing talking streamed into the ConfBridge.  The channel is then hung up.  After the conference has ended, a second local channel is connected to an extension that plays the recorded file into the BackgroundDetect application.  If talking is detected in the sound file and all expected events were received during scenario execution, the scenario passes.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/confbridge.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/confbridge.py 3157 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/tests.yaml 3157 
> 
> Diff: https://reviewboard.asterisk.org/r/1880/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120427/546cfda8/attachment-0001.htm>