[asterisk-dev] [Code Review] Add recording tests for ConfBridge

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1880/#review6086
-----------------------------------------------------------



/asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1880/#comment11176>

    Is this extension actually used?  Maybe you meant to use the 'h' extension?



/asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/1880/#comment11175>

    Is there any reason not to use Echo() here?



/asterisk/trunk/tests/apps/confbridge/confbridge_recording/run-test
<https://reviewboard.asterisk.org/r/1880/#comment11174>

    namedtuple is only available in python 2.6+ while centos5 runs python 2.4.


- opticron


On April 23, 2012, 8:27 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1880/
> -----------------------------------------------------------
> 
> (Updated April 23, 2012, 8:27 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a test to the Asterisk Test Suite to verify the recording of conferences by ConfBridge.  It checks three scenarios:
> 
> 1) Setting the record_conference bridge setting using the CONFBRIDGE function and using the default file name provided by the ConfBridge application.
> 2) Setting the record_conference and record_file bridge settings using the CONFBRIDGE function.
> 3) Using a non-default bridge profile from the ConfBridge config file.
> 
> In each scenario, a local channel is placed into a ConfBridge and a sound file containing talking streamed into the ConfBridge.  The channel is then hung up.  After the conference has ended, a second local channel is connected to an extension that plays the recorded file into the BackgroundDetect application.  If talking is detected in the sound file and all expected events were received during scenario execution, the scenario passes.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/confbridge.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/confbridge.py 3157 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/run-test PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/confbridge_recording/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/confbridge/tests.yaml 3157 
> 
> Diff: https://reviewboard.asterisk.org/r/1880/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120427/75094dc1/attachment.htm>