[asterisk-dev] [Code Review] Add testsuite tests for custom SIP INFO message generation

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1867/#review6008
-----------------------------------------------------------

Ship it!


The actual test looks good. There's a lot of seemingly-unrelated stuff regarding skipping tests added here as well. I've just ignored it for now since I assume it has something to do with a mismatch between your working copy and what's in SVN at the moment.


asterisk/trunk/tests/channels/SIP/custom_info/sipp/selected_useragent.xml
<https://reviewboard.asterisk.org/r/1867/#comment11033>

    Okay, this is pretty awesome. I wish I had known SIPP could do this in some earlier tests I wrote :)


- Mark


On April 13, 2012, 3:07 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1867/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 3:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> These tests ensure that custom SIP INFO message generation is functioning properly by injecting AST_CONTROL_CUSTOM frames into the calling channel and checking whether a message with the correct data is returned.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/TestConfig.py 3164 
>   asterisk/trunk/lib/python/asterisk/version.py 3164 
>   asterisk/trunk/runtests.py 3164 
>   asterisk/trunk/tests/channels/SIP/custom_info/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/custom_info/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/custom_info/run-test PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/custom_info/sipp/excluded_useragent.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/custom_info/sipp/selected_useragent.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/custom_info/sipp/send_all.xml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/custom_info/test-config.yaml PRE-CREATION 
>   asterisk/trunk/tests/channels/SIP/message_auth/test-config.yaml 3164 
>   asterisk/trunk/tests/channels/SIP/tests.yaml 3164 
> 
> Diff: https://reviewboard.asterisk.org/r/1867/diff
> 
> 
> Testing
> -------
> 
> Run in conjunction with the changes in review 1866.  This also needs the changes in review 1796 to be able to deal with the version changes introduced by digiumphones branches.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120417/e5f37bf6/attachment.htm>