<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1867/">https://reviewboard.asterisk.org/r/1867/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The actual test looks good. There&#39;s a lot of seemingly-unrelated stuff regarding skipping tests added here as well. I&#39;ve just ignored it for now since I assume it has something to do with a mismatch between your working copy and what&#39;s in SVN at the moment.</pre>
 <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/1867/diff/1/?file=27266#file27266line63" style="color: black; font-weight: bold; text-decoration: underline;">asterisk/trunk/tests/channels/SIP/custom_info/sipp/selected_useragent.xml</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">63</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="nt">&lt;action&gt;</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">64</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span class="c">&lt;!-- make sure the body has the text we expect --&gt;</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">65</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span class="nt">&lt;ereg</span> <span class="na">regexp=</span><span class="s">&quot;sent to certain UAs&quot;</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">66</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span class="na">search_in=</span><span class="s">&quot;body&quot;</span> <span class="na">check_it=</span><span class="s">&quot;true&quot;</span> <span class="na">assign_to=</span><span class="s">&quot;1&quot;</span><span class="nt">/&gt;</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">      <span class="nt">&lt;strcmp</span> <span class="na">assign_to=</span><span class="s">&quot;1&quot;</span> <span class="na">variable=</span><span class="s">&quot;1&quot;</span> <span class="na">value=</span><span class="s">&quot;&quot;</span><span class="nt">/&gt;</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">68</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="nt">&lt;/action&gt;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Okay, this is pretty awesome. I wish I had known SIPP could do this in some earlier tests I wrote :)</pre>
</div>
<br />



<p>- Mark</p>


<br />
<p>On April 13th, 2012, 3:07 p.m., opticron wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>


<p style="color: grey;"><i>Updated April 13, 2012, 3:07 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These tests ensure that custom SIP INFO message generation is functioning properly by injecting AST_CONTROL_CUSTOM frames into the calling channel and checking whether a message with the correct data is returned.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Run in conjunction with the changes in review 1866.  This also needs the changes in review 1796 to be able to deal with the version changes introduced by digiumphones branches.</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>asterisk/trunk/lib/python/asterisk/TestConfig.py <span style="color: grey">(3164)</span></li>

 <li>asterisk/trunk/lib/python/asterisk/version.py <span style="color: grey">(3164)</span></li>

 <li>asterisk/trunk/runtests.py <span style="color: grey">(3164)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/custom_info/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/custom_info/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/custom_info/run-test <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/custom_info/sipp/excluded_useragent.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/custom_info/sipp/selected_useragent.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/custom_info/sipp/send_all.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/custom_info/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/message_auth/test-config.yaml <span style="color: grey">(3164)</span></li>

 <li>asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(3164)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1867/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>