[asterisk-dev] [Code Review]: Dialplan function for manager account checks - AMI_CLIENT()

[Olle E Johansson]

> On July 28, 2010, 10:48 a.m., Tilghman Lesher wrote:
> > /trunk/main/manager.c, line 6099
> > <https://reviewboard.asterisk.org/r/421/diff/3/?file=11951#file11951line6099>
> >
> >     You need to assign the return value to args.name, in case there are leading spaces.

fixed.


> On July 28, 2010, 10:48 a.m., Tilghman Lesher wrote:
> > /trunk/main/manager.c, line 6100
> > <https://reviewboard.asterisk.org/r/421/diff/3/?file=11951#file11951line6100>
> >
> >     Ditto.

fixed


> On July 28, 2010, 10:48 a.m., Tilghman Lesher wrote:
> > /trunk/main/manager.c, line 6126
> > <https://reviewboard.asterisk.org/r/421/diff/3/?file=11951#file11951line6126>
> >
> >     read_max should be 12, not 2.  2 only covers the cases when the number of sessions < 10.

fixed


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/421/#review2483
-----------------------------------------------------------


On July 28, 2010, 4:20 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/421/
> -----------------------------------------------------------
> 
> (Updated July 28, 2010, 4:20 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Implementation of a dialplan function for checking manager accounts. I've made it extensible so that we can add other parameters when needed. Right now it only checks the number of logged in sessions for a manager account.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/manager.c 280055 
> 
> Diff: https://reviewboard.asterisk.org/r/421/diff
> 
> 
> Testing
> -------
> 
> Tested on my Linux system and it reports manager logins properly - 0, 1 and 2 concurrent sessions...
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110919/660b1d0c/attachment.htm>