[asterisk-dev] [Code Review]: Clean up dnsmgr.conf parsing

[Paul Belanger]

> On Sept. 13, 2011, 5:02 a.m., wdoekes wrote:
> > trunk/main/dnsmgr.c, line 390
> > <https://reviewboard.asterisk.org/r/1432/diff/1/?file=20564#file20564line390>
> >
> >     Why didn't you remove res completely (do return 0 instead)? It never holds anything other than 0, right?

Right, all code paths returned 0, so we just default to it now.


> On Sept. 13, 2011, 5:02 a.m., wdoekes wrote:
> > trunk/main/dnsmgr.c, line 407
> > <https://reviewboard.asterisk.org/r/1432/diff/1/?file=20564#file20564line407>
> >
> >     I see no reason for the if(config), no. I bet it's a leftover from when (if?) CONFIG_STATUS_FILEMISSING wasn't checked.

Thanks


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1432/#review4312
-----------------------------------------------------------


On Sept. 12, 2011, 7:26 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1432/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 7:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Another module that requires cleanup.  Also includes some coding guidelines formatting.
> 
> 
> Diffs
> -----
> 
>   trunk/main/dnsmgr.c 335386 
> 
> Diff: https://reviewboard.asterisk.org/r/1432/diff
> 
> 
> Testing
> -------
> 
> local development box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/8e8c8e3a/attachment-0001.htm>