[asterisk-dev] [Code Review] Clean up dnsmgr.conf parsing

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1432/#review4312
-----------------------------------------------------------

Ship it!


Cleanup is good.


trunk/main/dnsmgr.c
<https://reviewboard.asterisk.org/r/1432/#comment8406>

    Why didn't you remove res completely (do return 0 instead)? It never holds anything other than 0, right?



trunk/main/dnsmgr.c
<https://reviewboard.asterisk.org/r/1432/#comment8405>

    I see no reason for the if(config), no. I bet it's a leftover from when (if?) CONFIG_STATUS_FILEMISSING wasn't checked.


- wdoekes


On Sept. 12, 2011, 7:26 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1432/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 7:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Another module that requires cleanup.  Also includes some coding guidelines formatting.
> 
> 
> Diffs
> -----
> 
>   trunk/main/dnsmgr.c 335386 
> 
> Diff: https://reviewboard.asterisk.org/r/1432/diff
> 
> 
> Testing
> -------
> 
> local development box.
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110913/bf58108b/attachment.htm>