[asterisk-dev] [Code Review] "sipusers" only exists in documentation, and "sipfriends" is still used in documentation

wdoekes reviewboard at asterisk.org
Mon Oct 31 09:05:20 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1523/
-----------------------------------------------------------

(Updated Oct. 31, 2011, 9:05 a.m.)


Review request for Asterisk Developers and Terry Wilson.


Changes
-------

Added note to UPGRADE.txt.

(Don't forget the svn mv ...sipfriends.sql ...sippeers.sql)


Summary
-------

Since 1.6(.2?), "sipusers" has been gone from chan_sip. I suspect sippeers now does what sipfriends was supposed to do again, but changing the preferred the name back to sipfriends again sounds like a bad plan.

This patch removes all leftover references to sipusers and renames sipfriends to sippeers where possible.

(Reviewboard didn't let me upload the patch with 'svn mv ...sipfriends.sql ...sippeer.sql' , but the file should be renamed as well.)


Diffs (updated)
-----

  branches/1.8/UPGRADE.txt 342659 
  branches/1.8/configs/dbsep.conf.sample 342659 
  branches/1.8/configs/extconfig.conf.sample 342659 
  branches/1.8/configs/res_config_mysql.conf.sample 342659 
  branches/1.8/configs/res_ldap.conf.sample 342659 
  branches/1.8/contrib/realtime/mysql/sipfriends.sql 342659 
  branches/1.8/main/config.c 342659 
  branches/1.8/res/res_realtime.c 342659 

Diff: https://reviewboard.asterisk.org/r/1523/diff


Testing
-------

None whatsoever, but the only code changes involve removing 1 line and editing documentation strings.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111031/fb987947/attachment-0001.htm>


More information about the asterisk-dev mailing list