[asterisk-dev] [Code Review] Add hold status with CEL and setting a channel var HOLDING via ast_moh_stop/start

[whardier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1546/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This may help call centers and phone system administrators who are compiling analytic information based on call hold times or need events based notification of a call being placed on hold.

I liked the idea of querying CEL database sources for hold time information. In my workplace too many people hog phone calls and it's difficult to find a diplomatic solution that doesn't involve restricting call count.

On top of that I will be using ImportVar to check for the absence of a HOLDING channel variable for tagged channels in a list. Doing so allows me to automate through generic user interfaces and AMI hooks actions to be done on an active conversation - transfers, spying, and using ChanSPY and Playback for automated audio delivery. The goal here is to select the currently active call.

Using channel->moh_state might not work for what I want or be as predictable as I need it to be and it requires res_musiconhold to boot.

I'd prefer to write a helper function to query the channel var without using ImportVar but I wanted to get feedback first.

Also.. there is a potential problem with res_musiconhold where if there was a problem with initializing music on hold an event isn't passed to AMI, however when a call is removed from hold an event is sent regardless.


This addresses bug ASTERISK-18037.
    https://issues.asterisk.org/jira/browse/ASTERISK-18037


Diffs
-----

  /trunk/include/asterisk/cel.h 342541 
  /trunk/main/cel.c 342541 
  /trunk/main/channel.c 342541 
  /trunk/res/res_musiconhold.c 342541 

Diff: https://reviewboard.asterisk.org/r/1546/diff


Testing
-------

Brought into trunk from 1.8.4 where under 1.8.4 Linksys SPA9xx series phones and Bria 3 soft phone was used to test holding.

Tested under 1.8.7 and current (today) trunk using twinkle (two twinkle instances)


Thanks,

whardier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111026/a47ffa2a/attachment.htm>