[asterisk-dev] [Code Review] Preserve DTMF length in main/features.c

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1463/#review4564
-----------------------------------------------------------



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/1463/#comment8745>

    f->len is not good here.  Frame can very easily be null within this block of code, and if it is, trying to access f->len will cause a segfault... and in fact, messing about with google voice with the interns today exposed this very problem.
    
    Generally speaking you need to wait for someone internal to give a ship-it before committing code if you have commit access.  I don't actually know whether that status of people on reviewboard is actually viewable anywhere, so I guess for now the only real answer to that is that if you don't know, you need to ask on IRC.  I'm going to go ahead and fix these items since it's a pretty easy change, but just keep that in mind int he future.


- jrose


On Sept. 27, 2011, 8:53 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1463/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2011, 8:53 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When DTMF goes through features (because we're listening for some feature codes) the length is disregarded. This patch makes sure that the DTMF length doesn't disappear in a few cases.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/features.c 338029 
> 
> Diff: https://reviewboard.asterisk.org/r/1463/diff
> 
> 
> Testing
> -------
> 
> This is part of a larger branch that fixes a lot of DTMF issues.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111024/abf642d2/attachment.htm>