[asterisk-dev] [Code Review] app_queue change to have one devstate per device not per member / Janitorial cleanups

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1538/
-----------------------------------------------------------

Review request for Asterisk Developers and Matthew Nicholson.


Summary
-------

This is a rather large changeset but consists of the following

1)remove the taskprocessor it was used to process the state changes and this is perhaps not that efficient
2)remove check_state_unknown its not needed any more now that we can reserve a state interface
3)split state information into a new container (devices) the member holds a ref to it allowing shared state devices see above
4)realtime and paused are y/n so add a :1 to them
5)remove all defines for ao2 funcs and remove references to ao2_t_*
6)ao2 search callbacks can handle non OBJ_POINTER flag to make ao2_find useful no need to pass obj
7)Reservation of devices to pervent duplicate calls
8)quite a few ref leaks and even a q lock not ever released in some circumstances
9)whitespace / brace fixups

the whitespace / brace / ref / lock fixups ill be merging to 1.8 and then updateing this patch again the devstate fixes
should go into 10 related to the issue above the change from ao2_t and friends perhaps only for trunk.

Regards greg

PS have a awesome astricon


This addresses bug AST-695.
    https://issues.asterisk.org/jira/browse/AST-695


Diffs
-----

  /trunk/configs/queues.conf.sample 341804 
  /trunk/apps/app_queue.c 341804 

Diff: https://reviewboard.asterisk.org/r/1538/diff


Testing
-------

as most of the above [1,2,4,5,9] are removing code not referenced or changing syntax going over the .diff over and over makeing sure it builds and loads.

check state information is propogated and used in app_queue [3,7] 
make sure queues are loaded correctly and changes in [6,5] have not broken things


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111023/adeb9bcb/attachment.htm>