<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1538/">https://reviewboard.asterisk.org/r/1538/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Matthew Nicholson.</div>
<div>By irroot.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a rather large changeset but consists of the following
1)remove the taskprocessor it was used to process the state changes and this is perhaps not that efficient
2)remove check_state_unknown its not needed any more now that we can reserve a state interface
3)split state information into a new container (devices) the member holds a ref to it allowing shared state devices see above
4)realtime and paused are y/n so add a :1 to them
5)remove all defines for ao2 funcs and remove references to ao2_t_*
6)ao2 search callbacks can handle non OBJ_POINTER flag to make ao2_find useful no need to pass obj
7)Reservation of devices to pervent duplicate calls
8)quite a few ref leaks and even a q lock not ever released in some circumstances
9)whitespace / brace fixups
the whitespace / brace / ref / lock fixups ill be merging to 1.8 and then updateing this patch again the devstate fixes
should go into 10 related to the issue above the change from ao2_t and friends perhaps only for trunk.
Regards greg
PS have a awesome astricon
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as most of the above [1,2,4,5,9] are removing code not referenced or changing syntax going over the .diff over and over makeing sure it builds and loads.
check state information is propogated and used in app_queue [3,7]
make sure queues are loaded correctly and changes in [6,5] have not broken things</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/AST-695">AST-695</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configs/queues.conf.sample <span style="color: grey">(341804)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(341804)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1538/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>