[asterisk-dev] [Code Review]: Clean up cel.conf parsing

[rmudgett]

> On Oct. 20, 2011, 11:36 a.m., mjordan wrote:
> > trunk/main/cel.c, line 311
> > <https://reviewboard.asterisk.org/r/1436/diff/1/?file=20585#file20585line311>
> >
> >     Again, I personally think we should check for this before resetting old values.

Yes, it is bad to check if the config structure was read in correctly or is unchanged after resetting any existing config to defaults on a reload.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1436/#review4543
-----------------------------------------------------------


On Sept. 13, 2011, 3:29 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1436/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2011, 3:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This includes both [general] and [manager] sections for cel.conf.  We also no longer fail to load the module when the configuration file is missing, it will now use the defaults.
> 
> 
> Diffs
> -----
> 
>   trunk/main/cel.c 335603 
>   trunk/cel/cel_manager.c 335603 
> 
> Diff: https://reviewboard.asterisk.org/r/1436/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111020/c8f0e498/attachment-0001.htm>