[asterisk-dev] [Code Review] Clean up logger.conf parsing

[mjordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1457/#review4545
-----------------------------------------------------------



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1457/#comment8711>

    Why did you change the name of this?  In most places when parsing through ast_variable objects, we use 'var'.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1457/#comment8715>

    Since we set hostname to "unknown" (or, as proposed, the default Asterisk system name) if gethostname fails, this probably should never be set to NULL.  We should probably just copy our default name here.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1457/#comment8714>

    Can't use ast_log here, as there are no loggers at this point (plus, you don't know how they're configured anymore either)
    
    stdXXX is your only real option for reporting errors here.
    
    I would comment that the "What box has no hostname???" message could probably be replaced with a more descriptive warning message.



trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1457/#comment8716>

    These should probably be v->value, not v->name (subsequent lines as well)


- mjordan


On Sept. 23, 2011, 2:30 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1457/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 2:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch helps clean up logger.conf for parsing of the [general] section.
> 
> 
> Diffs
> -----
> 
>   trunk/main/logger.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1457/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111020/8017b801/attachment-0001.htm>