[asterisk-dev] [Code Review]: Fix several bugs with SDP parsing and well-formedness of responses

[opticron]

> On Oct. 12, 2011, 4:15 a.m., irroot wrote:
> > Nice job this should possibly be for 1.8 too ??

This will be applied to 1.8, 10, and trunk, since it deals with fixing protocol violations and doesn't involve invasive changes.


> On Oct. 12, 2011, 4:15 a.m., irroot wrote:
> > trunk/channels/chan_sip.c, lines 11530-11534
> > <https://reviewboard.asterisk.org/r/1516/diff/1/?file=21137#file21137line11530>
> >
> >     Be nice kill this red block / add braces

Done.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1516/#review4500
-----------------------------------------------------------


On Oct. 12, 2011, 9:17 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1516/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 9:17 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Fix bug ASTERISK-16558 which dealt with the order of responses to incoming streams defined by SDP.
> 
> Fix unreported bug where offering multiple same-type streams would cause Asterisk to reply with an incorrect SDP response missing one or more streams without a proper declination.
> 
> Fix bugs related to a single non-audio stream being offered with responses requesting codecs that were not offered in the initial invite along with an additional audio stream that was not in the initial invite.
> 
> 
> This addresses bug ASTERISK-16558.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16558
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 340161 
>   trunk/channels/sip/include/sip.h 340161 
> 
> Diff: https://reviewboard.asterisk.org/r/1516/diff
> 
> 
> Testing
> -------
> 
> Ran this through a large portion of the external testsuite, but it needs quite a bit more testing before commit.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111012/06bc7172/attachment.htm>