[asterisk-dev] [Code Review] Fix several bugs with SDP parsing and well-formedness of responses

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1516/#review4500
-----------------------------------------------------------


Nice job this should possibly be for 1.8 too ??


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1516/#comment8676>

    Be nice kill this red block / add braces


- irroot


On Oct. 11, 2011, 11:51 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1516/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2011, 11:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Fix bug ASTERISK-16558 which dealt with the order of responses to incoming streams defined by SDP.
> 
> Fix unreported bug where offering multiple same-type streams would cause Asterisk to reply with an incorrect SDP response missing one or more streams without a proper declination.
> 
> Fix bugs related to a single non-audio stream being offered with responses requesting codecs that were not offered in the initial invite along with an additional audio stream that was not in the initial invite.
> 
> 
> This addresses bug ASTERISK-16558.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16558
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 340161 
>   trunk/channels/sip/include/sip.h 340161 
> 
> Diff: https://reviewboard.asterisk.org/r/1516/diff
> 
> 
> Testing
> -------
> 
> Ran this through a large portion of the external testsuite, but it needs quite a bit more testing before commit.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111012/4636ff79/attachment-0001.htm>