[asterisk-dev] [Code Review] Allow dialplan control of faxdetection via faxdetect framehook / options in func CHANNEL

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated Oct. 2, 2011, 3:34 a.m.)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, may213, Leif Madsen, and dafe_von_cetin.


Changes
-------

1)Add a generic faxdetect framehook to res_fax that can [not yet] be put into channel.h and be used in channel drivers via res_fax
2)Add FAXOPT(faxdetect) to enable or disable this faxdetect framehook allowing dialplan control of faxdetecttion
3)Remove func OOH323 its not sound to have its on func the insides have been moved to func CHANNEL

app WaitFAX will fall away and is only in the patch for testing the internals

ill be adding bits to dahdi/misdn/sip to support CHANNEL(faxdetect) and will using this framehook as a callback in channel.h to implement it replacing there own faxdetect algo's


Summary (updated)
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bug ASTERISK-18569.
    https://issues.asterisk.org/jira/browse/ASTERISK-18569


Diffs (updated)
-----

  /trunk/addons/chan_ooh323.c 338894 
  /trunk/funcs/func_channel.c 338894 
  /trunk/include/asterisk/res_fax.h 338894 
  /trunk/res/res_fax.c 338894 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111002/92e68d89/attachment.htm>