[asterisk-dev] [Code Review] Don't play a new song for every new hold within a call with caching realtime MOH

Terry Wilson reviewboard at asterisk.org
Tue Nov 22 19:38:10 CST 2011

This is an automatically generated e-mail. To reply, visit:

Review request for Asterisk Developers.


As a result of the fix for ASTERISK-18039, realtime caching MOH no longer properly resumes playing back a file between different holds in the same call. This is because scanning for new files causes the existing file array to be emptied and we were just comparing that the saved pointer to the filename matched the pointer to the filename in a particular position in the array. An easy fix is to save the filename instead of a pointer to it and then do a strcmp instead of comparing the addresses.

This addresses bug ASTERISK-18912.


  /branches/1.8/res/res_musiconhold.c 346028 

Diff: https://reviewboard.asterisk.org/r/1596/diff


Tested adding and removing files from the moh directory and seeing that they were still picked up and that if we were playing a song and it still existed that we continued playing that song across multiple holds on the same call.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111123/640497e5/attachment-0001.htm>

More information about the asterisk-dev mailing list