[asterisk-dev] [Code Review] fix ast_str_truncate signedness warning and documentation

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1594/#review4847
-----------------------------------------------------------

Ship it!


Looks good.

- rmudgett


On Nov. 22, 2011, 3:10 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1594/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2011, 3:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> (1) strings.h:504:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
> (2) Doxygen docs didn't specify what a negative number means.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/include/asterisk/strings.h 345925 
> 
> Diff: https://reviewboard.asterisk.org/r/1594/diff
> 
> 
> Testing
> -------
> 
> Logic tells me the result should be the same while readability of the code has improved.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111123/ebe3ac2a/attachment.htm>