[asterisk-dev] [Code Review] fix ast_str_truncate signedness warning and documentation

wdoekes reviewboard at asterisk.org
Tue Nov 22 15:10:24 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1594/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

(1) strings.h:504:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
(2) Doxygen docs didn't specify what a negative number means.


Diffs
-----

  /branches/1.8/include/asterisk/strings.h 345925 

Diff: https://reviewboard.asterisk.org/r/1594/diff


Testing
-------

Logic tells me the result should be the same while readability of the code has improved.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111122/7f8877e3/attachment-0001.htm>


More information about the asterisk-dev mailing list