[asterisk-dev] [Code Review] Adds barriers to the menuselect easter egg

jrose reviewboard at asterisk.org
Thu Nov 10 14:43:13 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1556/#review4776
-----------------------------------------------------------


Also, Richard recommends just using svn up from the revision the patch was posted against.  This will work too and give you conflict markers so that you don't have to look at the patch yourself.

- jrose


On Nov. 2, 2011, 1:26 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1556/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2011, 1:26 p.m.)
> 
> 
> Review request for Asterisk Developers, David Vossel and jrose.
> 
> 
> Summary
> -------
> 
> Adds barriers to the cmenuselect easteregg.  They absorb shots, but fall apart quickly.  Also has support for different amounts of health on barriers, but this is currently set to one shot, one barrier killed.
> 
> Submitted by proxy for J'Len Dowdy.
> 
> 
> This addresses bug ASTERISK-18802.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18802
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect_curses.c 953 
> 
> Diff: https://reviewboard.asterisk.org/r/1556/diff
> 
> 
> Testing
> -------
> 
> Played through the easteregg a number of times to make sure it didn't explode under normal use conditions.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111110/060ef3b0/attachment.htm>


More information about the asterisk-dev mailing list