[asterisk-dev] [Code Review] Adds barriers to the menuselect easter egg

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1556/#review4775
-----------------------------------------------------------


Alright, awesome news, due to John's patch happening around the same areas as yours, this patch no longer merges cleanly into the source.

root at JonUbuntu:~/AsteriskWorkspace/menuselectMoreDumb/trunk/menuselect# patch -p0 < ../barrier.patch 
patching file menuselect_curses.c
Hunk #1 FAILED at 565.
Hunk #2 succeeded at 576 (offset 1 line).
Hunk #3 succeeded at 592 (offset 3 lines).
Hunk #4 succeeded at 640 (offset 3 lines).
Hunk #5 FAILED at 669.
Hunk #6 succeeded at 754 (offset 5 lines).
Hunk #7 succeeded at 796 (offset 5 lines).
Hunk #8 succeeded at 819 (offset 5 lines).
Hunk #9 FAILED at 853.
Hunk #10 FAILED at 892.
Hunk #11 succeeded at 951 (offset 42 lines).
4 out of 11 hunks FAILED -- saving rejects to file menuselect_curses.c.rej

Basically this sort of thing happens when code has changed to the point where the patching program can't find the pattern your changes were made from.

In order to fix this, you'll want to update to the latest menuselect and then you'll want to apply the patch as is and look at the conflicts and make your best judgement on how to resolve them.  In most cases, it probably won't be too difficult to just find out where a line was added or removed and you can just delete the failed patch indications and maybe have to move your code around a little.  Other times it can be a little more tricky, but I don't think that's going to be an issue here.

Once you fix this patch, post the new version to the issue and we'll resubmit it for review, and we'll probably just be able to put it in at that point.

- jrose


On Nov. 2, 2011, 1:26 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1556/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2011, 1:26 p.m.)
> 
> 
> Review request for Asterisk Developers, David Vossel and jrose.
> 
> 
> Summary
> -------
> 
> Adds barriers to the cmenuselect easteregg.  They absorb shots, but fall apart quickly.  Also has support for different amounts of health on barriers, but this is currently set to one shot, one barrier killed.
> 
> Submitted by proxy for J'Len Dowdy.
> 
> 
> This addresses bug ASTERISK-18802.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18802
> 
> 
> Diffs
> -----
> 
>   /trunk/menuselect_curses.c 953 
> 
> Diff: https://reviewboard.asterisk.org/r/1556/diff
> 
> 
> Testing
> -------
> 
> Played through the easteregg a number of times to make sure it didn't explode under normal use conditions.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111110/06eb12a3/attachment.htm>