[asterisk-dev] [Code Review] Get CDR Congestion Logging Test (and improving whole concept behind CDRTestCase) working.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1552/
-----------------------------------------------------------

(Updated Nov. 3, 2011, 2:48 p.m.)


Review request for Asterisk Developers, Paul Belanger and mjordan.


Changes
-------

Replaces print with log in CDRTestCase


Summary
-------

A while back, Pabelanger and I were working on creating a general method of testing CDR logging.  At the time, we sort of hit a wall with the order individual call logs were being stuffed into the master cdr file.

In order to alleviate that, this patch changes the CDRTestCase class to use CDR files generated based on account codes.  At the moment, I'm just specifically using a testsuite account code and loading that cdr file, but it isn't a stretch to say we could put in multiple account codes and use a bunch of different cdr logs so that the order of which channel hangs up isn't important.

In addition to that, a couple minor changes were made to the cdr_originate_sip_congestion_log test.  It now runs without any chance for timing based failures (before it was 50/50 whether congestion or failure would come first/second, now only one action is checked and logged, that being the congestion).

If this seems appropriate, I'll move forward with making the CDR Expectations use a variable to determine which file they should be checking against.


Diffs (updated)
-----

  /asterisk/team/group/cdr_test_log_congestion/lib/python/asterisk/CDRTestCase.py 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/cdr_originate_sip_congestion_log/configs/ast1/extensions.conf 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/cdr_originate_sip_congestion_log/configs/ast1/manager.general.conf.inc 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/cdr_originate_sip_congestion_log/configs/ast1/sip.conf 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/cdr_originate_sip_congestion_log/run-test 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/console_dial_sip_transfer/configs/ast1/branch-1.4/sip.conf 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/console_dial_sip_transfer/configs/ast2/branch-1.4/sip.conf 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/configs/ast1/cdr.conf 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/configs/ast1/extensions.conf 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/configs/ast1/sip.conf 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/sipp/data.csv 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-busy.xml 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-congestion.xml 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml 2657 
  /asterisk/team/group/cdr_test_log_congestion/tests/cdr/originate-cdr-disposition/sipp/wait-for-call.xml 2657 

Diff: https://reviewboard.asterisk.org/r/1552/diff


Testing
-------

Checked to see how the test was logging CDR in separate files, made sure test was passing appropriately.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111103/4440c3c7/attachment.htm>