[asterisk-dev] [Code Review] Add mute all participants; play participant count to ConfBridge

[Matthew Jordan]

If we go with the solution to mute all but admins, then we can look into something like this.  However, the underlying architecture of app_confbridge is not the same as app_meetme.  There is a large benefit to using the bridge channel (chan_bridge) for message playback, as it cleanly abstracts out the mechanisms for writing to each individual channel, e.g., safely locking the channels, etc.  Reproducing this functionality in app_confbridge - unless absolutely necessary - is generally something I'd like to avoid as it breaks the abstraction that chan_bridge provides and makes the codebase that much more difficult to maintain.

Matthew Jordan
Digium, Inc. | Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org

----- Original Message -----
From: "Tony Mountifield" <tony at softins.co.uk>
To: asterisk-dev at lists.digium.com
Sent: Thursday, November 3, 2011 12:22:20 PM
Subject: Re: [asterisk-dev] [Code Review] Add mute all participants;	play participant count to ConfBridge

In article <20111103170127.22261.77525 at hotblack.digium.com>,
David Vossel <reviewboard at asterisk.org> wrote:
> /trunk/apps/app_confbridge.c
> <https://reviewboard.asterisk.org/r/1518/#comment8861>
> 
>     Umm, if we don't mute the admin, the admin will still hear the sound file that they are
> muted, but they won't actually be muted.  Then when the admin starts making fun of people in
> the conference everyone will hear them even though the admin was told the line is muted. 
> This may or may not be the expected behavior.
>     
>     It might be better to go ahead and make this function mute everyone and make the admins
> explicitly unmute themselves after mute all is used. If we don't do it this way, we should
> make sure to comment in the documentation that the admin will not be affected by this
> action.

Since the status of being muted is an attribute of an individual
conference member, it should be announced separately to each user on
their channel. Even if there is a command to mute all, they should
still be told individually, rather than in a conference announcement.
Then if the command doesn't mute admins, it still works correctly,
without misleading anyone!

I have custom modifications to Meetme that work exactly like this.

Just my 2p

Cheers
Tony
-- 
Tony Mountifield
Work: tony at softins.co.uk - http://www.softins.co.uk
Play: tony at mountifield.org - http://tony.mountifield.org

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev