[asterisk-dev] [asterisk-commits] wdoekes: trunk r343163 - in /trunk: ./ include/asterisk/ main/

Kevin P. Fleming kpfleming at digium.com
Thu Nov 3 07:24:51 CDT 2011

On 11/03/2011 03:07 AM, Walter Doekes wrote:
> On 03/11/11 00:10, Kevin P. Fleming wrote:
>> Sorry I didn't get to this while it was still on ReviewBoard; I agree
>> with these changes, they are the right thing to do. The only additional
>> comment that I would make is that I would prefer to use
>> "alignof(ast_string_field_allocation)" instead of
>> "aligned(sizeof(...))". This allows the compiler to tell you how an
>> instance of that type should be aligned, which *might* not be on a
>> boundary the same as its size. Granted, for all common platforms the
>> alignment of a 2-byte integer is also 2 bytes... but it's conceivable
>> that some platform might want to align 2-byte integers on 4-byte
>> boundaries in the future.
> Ah. I didn't know that existed. That would indeed better.
> Can I safely make such changes afterwards in a mini commit? Same
> question applies for something like
> http://lists.digium.com/pipermail/asterisk-dev/2011-November/052046.html
> where a couple of integers need to be moved back.

Yes, feel free to make 'correction' commits like that without going 
through review.

> And if I can, can I join those unrelated changes into a single commit?

Nope; that's not possible with Subversion. It is possible with 
Git/Mercurial/etc., but not a good idea if the original commits have 
already been published.

Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
Jabber: kfleming at digium.com | SIP: kpfleming at digium.com | Skype: kpfleming
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at www.digium.com & www.asterisk.org

More information about the asterisk-dev mailing list