[asterisk-dev] [Code Review] chan_sip registertrying lacks a global option

[Terry Wilson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1540/#review4643
-----------------------------------------------------------


As an alternative, I propose removing the option completely: https://reviewboard.asterisk.org/r/1562/

- Terry


On Oct. 24, 2011, 3:51 p.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1540/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2011, 3:51 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Regarding my (*) at:
> http://lists.digium.com/pipermail/asterisk-dev/2011-October/051868.html
> 
> I did a little tweaking to the 100-on-REG functionality:
> 
> (1) Check peer->flags, not p->flags. The peer object holds the details about whether the user wants the extra 100.
> (2) Added a global option, so registertrying=yes|no can be set in [general]
> (3) Defaulted the global option to OFF
> (4) Updated the alwaysauthreject-default comment which was reversed. (The boolean was changed, but the comment wasn't.)
> (5) Move SIP_PAGE2_REGISTERTRYING to bit 29 because bit 24 was actually in use by T38 options (spotted by Pavel Troller a couple of weeks ago)
> 
> There is the issue left that the registertrying= option has the same username-disclosure-potential as the nat=yes that is being discussed in http://lists.digium.com/pipermail/asterisk-dev/2011-October/051848.html . One could argue that the only the global option should be kept and the per-peer option could be removed.
> 
> I don't have an opinion about this. I would set it to off by default and I've never needed it to be on.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 342060 
>   /trunk/channels/sip/include/sip.h 342060 
> 
> Diff: https://reviewboard.asterisk.org/r/1540/diff
> 
> 
> Testing
> -------
> 
> I've tested the 4 combinations and they work.
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111102/c7fcdd87/attachment-0001.htm>