<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1540/">https://reviewboard.asterisk.org/r/1540/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As an alternative, I propose removing the option completely: https://reviewboard.asterisk.org/r/1562/</pre>
<br />
<p>- Terry</p>
<br />
<p>On October 24th, 2011, 3:51 p.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Oct. 24, 2011, 3:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding my (*) at:
http://lists.digium.com/pipermail/asterisk-dev/2011-October/051868.html
I did a little tweaking to the 100-on-REG functionality:
(1) Check peer->flags, not p->flags. The peer object holds the details about whether the user wants the extra 100.
(2) Added a global option, so registertrying=yes|no can be set in [general]
(3) Defaulted the global option to OFF
(4) Updated the alwaysauthreject-default comment which was reversed. (The boolean was changed, but the comment wasn't.)
(5) Move SIP_PAGE2_REGISTERTRYING to bit 29 because bit 24 was actually in use by T38 options (spotted by Pavel Troller a couple of weeks ago)
There is the issue left that the registertrying= option has the same username-disclosure-potential as the nat=yes that is being discussed in http://lists.digium.com/pipermail/asterisk-dev/2011-October/051848.html . One could argue that the only the global option should be kept and the per-peer option could be removed.
I don't have an opinion about this. I would set it to off by default and I've never needed it to be on.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested the 4 combinations and they work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(342060)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(342060)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1540/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>